Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace assert with CHECK_LE in node_api.cc #14514

Merged
merged 2 commits into from
Aug 7, 2017
Merged

src: replace assert with CHECK_LE in node_api.cc #14514

merged 2 commits into from
Aug 7, 2017

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jul 27, 2017 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 27, 2017
TimothyGu
TimothyGu suggested changes Aug 1, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm going to have renege on my LGTM earlier. This file is AFAIK shared with an outside project that don't have access to the internal CHECK macros. I remember @gabrielschulhof said this might not be true any more after #14217 (comment), but I'd like to block this first before confirmation that such change is acceptable.

/cc @nodejs/n-api

@jasongin
Copy link
Member

jasongin commented Aug 1, 2017

@TimothyGu Actually the CHECK macros are OK to use now in node_api.cc. They are defined for the node-addon-api project at https://github.com/nodejs/node-addon-api/blob/master/src/node_internals.h#L33

@bnoordhuis
src: replace assert with CHECK_LE in node_api.cc
f3afe29 
PR-URL: nodejs#14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
@bnoordhuis
src: remove unused Connection::ClearError()
e658d32 
PR-URL: nodejs#14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
@bnoordhuis bnoordhuis closed this Aug 7, 2017
@bnoordhuis bnoordhuis deleted the ndebug branch August 7, 2017 12:25
@bnoordhuis bnoordhuis merged commit e658d32 into nodejs:master Aug 7, 2017
@bnoordhuis bnoordhuis mentioned this pull request Aug 7, 2017
Closed
addaleax pushed a commit that referenced this pull request Aug 7, 2017
@bnoordhuis @addaleax
src: replace assert with CHECK_LE in node_api.cc
4b01d8c 
PR-URL: #14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Aug 7, 2017
@bnoordhuis @addaleax
src: remove unused Connection::ClearError()
eb068a0 
PR-URL: #14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
@MylesBorins
Copy link
Contributor

@bnoordhuis LTS?

@bnoordhuis
Copy link
Member Author

Won't hurt.

@MylesBorins
Copy link
Contributor

only one of these two changes apply to the branch. for the sake of simplicity I'm going to label this do not land.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@bnoordhuis
src: replace assert with CHECK_LE in node_api.cc
3be9e95 
PR-URL: nodejs#14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@bnoordhuis @MylesBorins
src: replace assert with CHECK_LE in node_api.cc
0ef0b34 
Backport-PR-URL: #19447
PR-URL: #14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongin jasongin jasongin approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.