Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-npm-install flaky on arm #14035

Merged
merged 1 commit into from
Jul 2, 2017
Merged

test: mark test-npm-install flaky on arm #14035

merged 1 commit into from
Jul 2, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented Jul 2, 2017

Ref: #14015
We deserve some green in our life (or at least Yellow)

Checklist
Affected core subsystem(s)

test,npm,arm

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 2, 2017
@refack
Copy link
Contributor Author

refack commented Jul 2, 2017

/cc @nodejs/testing @nodejs/platform-arm @nodejs/npm

@refack
Copy link
Contributor Author

refack commented Jul 2, 2017

Fasttrack?

@refack refack added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jul 2, 2017
@refack
test: mark test-npm-install flaky on arm
ed19a18 
PR-URL: nodejs#14035
Refs: nodejs#14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@refack refack merged commit ed19a18 into nodejs:master Jul 2, 2017
@refack
Copy link
Contributor Author

refack commented Jul 2, 2017

Although it did not fail in the last few hours, the yellow ⚠️ will remind us to take care of this.

@refack refack deleted the flake-npm-install-arm branch July 3, 2017 18:21
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
@addaleax
test: mark test-npm-install flaky on arm
8658868 
PR-URL: nodejs#14035
Refs: nodejs#14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax mentioned this pull request Jul 3, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@refack @addaleax
test: mark test-npm-install flaky on arm
7b08df8 
PR-URL: #14035
Refs: #14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@refack @addaleax
test: mark test-npm-install flaky on arm
cfb6f94 
PR-URL: #14035
Refs: #14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
@refack @MylesBorins
test: mark test-npm-install flaky on arm
448c8d4 
PR-URL: #14035
Refs: #14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@refack @Fishrock123
test: mark test-npm-install flaky on arm
66a6a5e 
PR-URL: #14035
Refs: #14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
@refack @MylesBorins
test: mark test-npm-install flaky on arm
a3e2560 
PR-URL: #14035
Refs: #14015
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @lpinca @cjihrig @gibfahn @nodejs-github-bot