Skip to content

url: normalize port on scheme change #13997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

url: normalize port on scheme change #13997

wants to merge 1 commit into from

Conversation

@TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Jun 30, 2017

Refs: whatwg/url#328

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 30, 2017
TimothyGu added a commit that referenced this pull request Jul 5, 2017
@TimothyGu
url: normalize port on scheme change
b01ac75 
PR-URL: #13997
Refs: whatwg/url#328
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@TimothyGu
Copy link
Member Author

TimothyGu commented Jul 5, 2017

(I accidentally landed this in master w/o a CI run. Force-pushed after a few seconds to remove that commit.)

CI: https://ci.nodejs.org/job/node-test-pull-request/8984/

@TimothyGu
Copy link
Member Author

TimothyGu commented Jul 5, 2017

Landed in b01ac75.

@TimothyGu TimothyGu closed this Jul 5, 2017
@TimothyGu TimothyGu deleted the url-port-protocol branch July 5, 2017 05:31
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@TimothyGu @addaleax
url: normalize port on scheme change
9e87501 
PR-URL: #13997
Refs: whatwg/url#328
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax addaleax mentioned this pull request Jul 11, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@TimothyGu @addaleax
url: normalize port on scheme change
cf6afe3 
PR-URL: #13997
Refs: whatwg/url#328
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@TimothyGu @Fishrock123
url: normalize port on scheme change
c83b3ae 
PR-URL: #13997
Refs: whatwg/url#328
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

+1 more reviewer

@watilde watilde watilde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TimothyGu @jasnell @watilde @targos @nodejs-github-bot