Skip to content

Conversation

@watilde
Copy link
Contributor

@watilde watilde commented Jun 28, 2017

Summary
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition
Checklist
  • make -j4 test
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2017
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition

PR-URL: nodejs#13970
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
@watilde watilde force-pushed the feature/docs-style branch from 9257269 to ce11e0c Compare July 3, 2017 08:59
@watilde
Copy link
Contributor Author

watilde commented Jul 3, 2017

@watilde
Copy link
Contributor Author

watilde commented Jul 3, 2017

landed in 8b2c61c. thanks.

@watilde watilde closed this Jul 3, 2017
@watilde watilde deleted the feature/docs-style branch July 3, 2017 09:06
watilde added a commit that referenced this pull request Jul 3, 2017
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition

PR-URL: #13970
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
@addaleax
Copy link
Member

addaleax commented Jul 3, 2017

Adding dont-land-on-v8.x because it’s a tiny format change and doesn’t apply cleanly, feel free to raise a backport PR if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants