src: redo unaligned access workaround #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@indutny Would you be willing to review this PR? Thanks. |
| if (encoding == UCS2) { | ||
| assert(reinterpret_cast<uintptr_t>(buf) % sizeof(uint16_t) == 0 && | ||
| "UCS2 buffer must be aligned on two-byte boundary."); | ||
| return Encode(isolate, static_cast<const uint16_t*>(buf), len / 2); |
There was a problem hiding this comment.
Why using sizeof(uint16_t) above, if you are using 2 here?
There was a problem hiding this comment.
Good point. How does 56fde66 look?
|
LGTM |
Introduce two-byte overloads of node::Encode() and StringBytes::Encode() that ensure that the input is suitably aligned. Revisits commit 535fec8 from yesterday.
Move the big endian to little endian conversion logic for UCS2 input from src/string_bytes.cc to src/node_buffer.cc; StringSlice() is the only function that actually needs it and with this commit, a second copy is avoided on big endian architectures.
bnoordhuis
force-pushed
the
better-unaligned-access-fix
branch
from
beb3d1e
to
52fc406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@trevnorris