Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix incorrect fs.utimes() link #13608

Closed
wants to merge 1 commit into from
Closed

docs: fix incorrect fs.utimes() link #13608

wants to merge 1 commit into from

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jun 11, 2017 •
edited
Loading

Checklist
Affected core subsystem(s)
  • docs

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jun 11, 2017
@refack
Copy link
Contributor

refack commented Jun 11, 2017

Note: old link (erroneously) points to fs.futimes

Trott
Trott approved these changes Jun 11, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think this needs to wait 48/72 hours.

@Trott
Copy link
Member

Trott commented Jun 11, 2017

Minor thing: The subsystem in the commit message should be doc: rather than docs:. I'm fixing it in landing right now so need to change it on your end, but for future reference...

Trott pushed a commit to Trott/io.js that referenced this pull request Jun 11, 2017
@JustinBeckwith @Trott
doc: fix incorrect fs.utimes() link
a2ed3a9 
PR-URL: nodejs#13608
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 11, 2017 •
edited
Loading

Landed in a2ed3a9. Thanks, @JustinBeckwith and congrats on your first commit to Node.js core!

@Trott Trott closed this Jun 11, 2017
addaleax pushed a commit that referenced this pull request Jun 12, 2017
@JustinBeckwith @addaleax
doc: fix incorrect fs.utimes() link
70432f2 
PR-URL: #13608
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax mentioned this pull request Jun 12, 2017
Merged
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JustinBeckwith @refack @Trott @MylesBorins @lpinca @cjihrig @nodejs-github-bot