test: add hasCrypto check to async-wrap-GH13045 #13141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test currently fails if node was configured --without-ssl. This commit adds crypto check and skips this test if crypto support is not available.
cjihrig
approved these changes
May 21, 2017
santigimeno
approved these changes
May 21, 2017
lpinca
approved these changes
May 22, 2017
jasnell
approved these changes
May 22, 2017
|
test/osx failure looks unrelated to this PR. |
danbev
added a commit
to danbev/node
that referenced
this pull request
May 23, 2017
This test currently fails if node was configured --without-ssl. This commit adds crypto check and skips this test if crypto support is not available. PR-URL: nodejs#13141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 485be99 |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
This test currently fails if node was configured --without-ssl. This commit adds crypto check and skips this test if crypto support is not available. PR-URL: #13141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
This test currently fails if node was configured --without-ssl. This commit adds crypto check and skips this test if crypto support is not available. PR-URL: #13141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
This was referenced Dec 1, 2023
This was referenced May 14, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test currently fails if node was configured --without-ssl. This
commit adds crypto check and skips this test if crypto support is
not available.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test