util: fixup internal util exports #12998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
util.promisify landed without using the module.exports = {}
pattern. This fixes it up for consistency
nodejs-github-bot
added
the
util
addaleax
approved these changes
May 12, 2017
cjihrig
approved these changes
May 12, 2017
targos
approved these changes
May 12, 2017
lpinca
approved these changes
May 12, 2017
jasnell
added a commit
that referenced
this pull request
May 15, 2017
util.promisify landed without using the module.exports = {}
pattern. This fixes it up for consistency
PR-URL: #12998
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in ef16319 |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
util.promisify landed without using the module.exports = {}
pattern. This fixes it up for consistency
PR-URL: nodejs#12998
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.promisify landed without using the module.exports = {} pattern. This fixes it up for consistency
/cc @addaleax @refack
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util