Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-fs-symlink-dir-junction-relative #129

Closed
wants to merge 1 commit into from
Closed

test: fix test-fs-symlink-dir-junction-relative #129

wants to merge 1 commit into from

Conversation

piscisaureus
Copy link
Contributor

  • The test no longer relies on being invoked from a particular
    working directory to function properly.
  • fs.symlink() and fs.symlinkSync() are both tested.
  • The test now cleans up after itself.

This commit fixes #126

R=@bnoordhuis

@piscisaureus
test: fix test-fs-symlink-dir-junction-relative
68ba608 
  * The test no longer relies on being invoked from a particular
    working directory to function properly.
  * fs.symlink() and fs.symlinkSync() are both tested.
  * The test now cleans up after itself.

This commit fixes nodejs#126

R=@bnoordhuis
@bnoordhuis
Copy link
Member

I would perhaps drop the console.log() statements on the premise that a passing test is a quiet test - but LGTM.

piscisaureus added a commit that referenced this pull request Dec 9, 2014
@piscisaureus
test: fix test-fs-symlink-dir-junction-relative
4efc02a 
  * The test no longer relies on being invoked from a particular
    working directory to function properly.
  * fs.symlink() and fs.symlinkSync() are both tested.
  * The test now cleans up after itself.

This commit fixes #126

PR-URL: #129
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@piscisaureus piscisaureus deleted the fix-test-junction-relative branch December 9, 2014 20:17
@piscisaureus
Copy link
Contributor Author

I would perhaps drop the console.log() statements
Did that.

@snig-b snig-b mentioned this pull request May 23, 2016
Closed
@mearns mearns mentioned this pull request Jun 7, 2016
Closed
@nadiasvertex nadiasvertex mentioned this pull request Jul 14, 2016
Closed
@asuchac asuchac mentioned this pull request Oct 5, 2016
Closed
boingoing pushed a commit to boingoing/node that referenced this pull request Apr 6, 2017
@jasongin
Remove napi registration code from node.cc (V8) (nodejs#129)
14318a8 
* Remove napi registration code from node.cc

* make napi_module_register extern "C"
@wmertens wmertens mentioned this pull request Jun 19, 2020
Closed
@RaisinTen RaisinTen mentioned this pull request Dec 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 17, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 30, 2021
Open
This was referenced Sep 1, 2021
Open
Open
This was referenced Sep 13, 2021
Open
Open
Open
Open
Open
Open
@solebox solebox mentioned this pull request May 13, 2022
Open
@enterstudio enterstudio mentioned this pull request May 14, 2022
Open
@UbuntuEvangelist UbuntuEvangelist mentioned this pull request May 14, 2022
Open
@s4sc s4sc mentioned this pull request May 14, 2022
Open
@AshdonG AshdonG mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @bnoordhuis