add missing option to node PrintHelp #12763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Member
|
Could you update the commit message to something like |
addaleax
added
the
cli
krydos
force-pushed
the
node-print-help-fix
branch
from
28058a6 to
1ea0b01
Compare
Contributor
Author
|
@addaleax sure, thank you for the help ;) |
krydos
force-pushed
the
node-print-help-fix
branch
from
1ea0b01 to
43545c3
Compare
Contributor
|
Does this need to be added to |
addaleax
approved these changes
Apr 30, 2017
Contributor
Author
|
@cjihrig it is already there :) output of the --help option is the only place I found where |
cjihrig
approved these changes
Apr 30, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Thanks for double checking. LGTM
watilde
approved these changes
Apr 30, 2017
richardlau
approved these changes
Apr 30, 2017
Member
Contributor
Author
|
CI failed :( but seems unrelated. |
Member
|
Landed in 896be83 |
addaleax
pushed a commit
that referenced
this pull request
May 3, 2017
PR-URL: #12763 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
PR-URL: nodejs#12763 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the
--pending-deprecationoption was missed fromPrintHelpoutput of node. The option exists in doc files and of course it is handled by node itself.P.S.
excuse me, I don't really know what core subsystem it is, so I skip it below.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)