test: fix warning in n-api reference test #12730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cast to avoid warning during build of addon.
nodejs-github-bot
added
node-api
jasnell
approved these changes
Apr 28, 2017
cjihrig
approved these changes
Apr 28, 2017
addaleax
requested changes
Apr 30, 2017
| @@ -61,7 +61,7 @@ napi_value CheckExternal(napi_env env, napi_callback_info info) { | |||
| NAPI_ASSERT(env, argtype == napi_external, "Expected an external value.") | |||
|
|
|||
| int* data; | |||
| NAPI_CALL(env, napi_get_value_external(env, arg, &data)); | |||
| NAPI_CALL(env, napi_get_value_external(env, arg, (void*)&data)); | |||
There was a problem hiding this comment.
This should be void**, not void*. Alternatively, you could also lose the pointer-to-pointer cast and do it the safe way:
void* data;
napi_get_value_external(env, arg, &data);
data != NULL && *(int*)data == test_value
|
@addaleax pushed commit to fix. |
addaleax
approved these changes
May 1, 2017
|
Landed in 8aca66a |
addaleax
pushed a commit
that referenced
this pull request
May 3, 2017
Add cast to avoid warning during build of addon. PR-URL: #12730 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Add cast to avoid warning during build of addon. PR-URL: nodejs#12730 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Add cast to avoid warning during build of addon. PR-URL: nodejs#12730 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cast to avoid warning during build of addon.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api