test: move test to sequential for reliability #12704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. Fixes: nodejs#10130
Trott
added
freebsd
Member
Author
Member
Author
|
Stress test on this PR: https://ci.nodejs.org/job/node-stress-single-test/nodes=freebsd10-64/1179/console Stress test on master showing failures: https://ci.nodejs.org/job/node-stress-single-test/1177/nodes=freebsd10-64/console |
cjihrig
approved these changes
Apr 27, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM if it passes the stress test.
gibfahn
approved these changes
Apr 27, 2017
hiroppy
approved these changes
Apr 28, 2017
jasnell
approved these changes
Apr 28, 2017
santigimeno
approved these changes
Apr 28, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 30, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: nodejs#12704 Fixes: nodejs#10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
Author
|
Landed in 0833d31 |
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: #12704 Fixes: #10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: #12704 Fixes: #10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: #12704 Fixes: #10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas
pushed a commit
that referenced
this pull request
May 3, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: #12704 Fixes: #10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: #12704 Fixes: #10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
test-https-set-timeout-server fails under load. Move it to sequential so it is not competing with other tests. PR-URL: nodejs/node#12704 Fixes: nodejs/node#10130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.
Fixes: #10130
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test https freebsd