deps: backport dd310b4341 from upstream V8 #12696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v7.x
v8 engine
Original commit message:
[crankshaft] Fix string addition to check for max length of cons string.
BUG=chromium:678917
Review-Url: https://codereview.chromium.org/2653623002
Cr-Commit-Position: refs/heads/master@{nodejs#42621}
Fixes: nodejs#12573
bnoordhuis
approved these changes
Apr 28, 2017
There was a problem hiding this comment.
LGTM, thanks.
Node CI: https://ci.nodejs.org/job/node-test-pull-request/7728/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/670/
targos
approved these changes
May 12, 2017
targos
pushed a commit
that referenced
this pull request
May 12, 2017
Original commit message:
[crankshaft] Fix string addition to check for max length of cons string.
BUG=chromium:678917
Review-Url: https://codereview.chromium.org/2653623002
Cr-Commit-Position: refs/heads/master@{#42621}
PR-URL: #12696
Fixes: #12573
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 50e60e9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #12573
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps