Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use block scope in test-buffer-swap.js #12590

Closed
wants to merge 1 commit into from
Closed

test: use block scope in test-buffer-swap.js #12590

wants to merge 1 commit into from

Conversation

Zahidul-Islam
Copy link

@Zahidul-Islam Zahidul-Islam commented Apr 22, 2017 •
edited by mscdex
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 22, 2017
@Zahidul-Islam Zahidul-Islam changed the title refactoring: use block scope in test-buffer-swap.js test: use block scope in test-buffer-swap.js Apr 22, 2017
@mscdex
Copy link
Contributor

mscdex commented Apr 22, 2017

I believe this is already being done in #12544.

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Apr 22, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 22, 2017
@Trott
Copy link
Member

Trott commented Apr 22, 2017

I believe this is already being done in #12544.

Argh! My fault! Sorry. Hopefully it was a good exercise anyway just to get things set up for your next commit!

@Trott Trott closed this Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zahidul-Islam @mscdex @Trott @nodejs-github-bot @ChatbotSchool