test: replace common.PORT in test-cluster-dgram-2 #12492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace common.PORT with available port assigned by the operating system in test-cluster-dgram-2.
Trott
added
cluster
64 tasks
cjihrig
approved these changes
Apr 18, 2017
hiroppy
approved these changes
Apr 18, 2017
jasnell
requested changes
Apr 18, 2017
| @@ -81,7 +82,7 @@ function worker() { | |||
| // There is no guarantee that a sent dgram packet will be received so keep | |||
| // sending until disconnect. | |||
| const interval = setInterval(() => { | |||
| socket.send(buf, 0, buf.length, common.PORT, '127.0.0.1'); | |||
| socket.send(buf, 0, buf.length, process.env.BOUNDPORT, '127.0.0.1'); | |||
There was a problem hiding this comment.
may be worthwhile adding an assert to make sure process.env.BOUNDPORT is set
santigimeno
reviewed
Apr 18, 2017
| const port = socket.address().port; | ||
| // Fork workers. | ||
| for (let i = 0; i < NUM_WORKERS; i++) | ||
| cluster.fork({BOUNDPORT: port}); |
|
It looks like a duplicate of #12487 |
|
Closing in favor of #12487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace common.PORT with available port assigned by the operating
system in test-cluster-dgram-2.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test dgram cluster