-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix parallel/test-setproctitle.js on alpine #12413
Conversation
This breaks on FreeBSD apparently:
Ping @nodejs/build regarding CI failures:
https://ci.nodejs.org/job/node-test-commit-osx/9018/nodes=osx1010/console |
This shouldn't be an issue. |
@benjamingr the xcodebuild warnings aren't an issue (see nodejs/node-gyp#1057) xcodebuild is called twice but never actually used. |
There are definite failures in CI with this that need looking at |
72b31fe
to
d9e2793
Compare
bf0798a
to
85a2592
Compare
85a2592
to
9a78bea
Compare
Updated, and CI looks good now 😃 |
Landed in ee0620b |
Doesn't backport cleanly for me to v6.x, would you be willing to backport? If yes please follow the guide and raise a backport PR, if no let me know or add the |
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. PR-URL: nodejs#12413 Fixes: nodejs#12399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. Backport-PR-URL: #13072 PR-URL: #12413 Fixes: #12399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. Backport-PR-URL: #13072 PR-URL: #12413 Fixes: #12399 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Fixes: #12399
As mentioned in the ref issue, since Busybox
ps
does not support-p
switch, usingps -o
andgrep
instead to get the process title and then check it.The
title
variable in this test script was also renamed from'testme'
to'test'
, because it seems that on alpine if trying to set the process title to a string whose length is >=5 like'abcde'
, it will become{abcde} abcd
inps
output:Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test