Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: fix crash on fatal error in debug context #1229

Merged
merged 1 commit into from
Mar 22, 2015

Commits on Mar 22, 2015

  1. vm: fix crash on fatal error in debug context

    Ensure that the debug context has an Environment assigned in case
    a fatal error is raised.
    
    The fatal exception handler in node.cc is not equipped to deal with
    contexts that don't have one and can't easily be taught that due to
    a deficiency in the V8 API: there is no way for the embedder to tell
    if the data index is in use.
    
    Fixes: nodejs#1190
    PR-URL: nodejs#1229
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis committed Mar 22, 2015
    Configuration menu
    Copy the full SHA
    cf081a4 View commit details
    Browse the repository at this point in the history