Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark child-process-exec-kill-throws flaky #12054

Merged
merged 1 commit into from
Mar 27, 2017
Merged

test: mark child-process-exec-kill-throws flaky #12054

merged 1 commit into from
Mar 27, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 26, 2017

Refs: #12053
Refs: #11038

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines][]
Affected core subsystem(s)

test

cc/ @cjihrig @nodejs/testing @nodejs/platform-windows

@gibfahn gibfahn added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Mar 26, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 26, 2017
@gibfahn gibfahn mentioned this pull request Mar 26, 2017
Closed
@gibfahn
Copy link
Member Author

gibfahn commented Mar 26, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit/8698/

EDIT: Windows seems to be green.

@aqrln aqrln mentioned this pull request Mar 27, 2017
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Mar 27, 2017

I'd prefer to get this landed sooner than later so we can unbreak CI

@gibfahn gibfahn self-assigned this Mar 27, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Mar 27, 2017

Landing...

@gibfahn
test: mark child-process-exec-kill-throws flaky
66e7dc5 
PR-URL: nodejs#12054
Ref: nodejs#12053
Ref: nodejs#11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@gibfahn gibfahn merged commit 66e7dc5 into nodejs:master Mar 27, 2017
@gibfahn gibfahn deleted the flaky-exec-kill-win branch March 27, 2017 17:47
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@gibfahn @MylesBorins
test: mark child-process-exec-kill-throws flaky
8b2b93f 
PR-URL: #12054
Ref: #12053
Ref: #11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@gibfahn gibfahn

Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gibfahn @jasnell @santigimeno @cjihrig @richardlau @MylesBorins @nodejs-github-bot