Skip to content

test: add second argument to assert.throws() #12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rjbernaldo wants to merge 1 commit into from
Closed

test: add second argument to assert.throws() #12016

rjbernaldo wants to merge 1 commit into from

Conversation

@rjbernaldo
Copy link
Contributor

@rjbernaldo rjbernaldo commented Mar 24, 2017 •
edited
Loading

Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 24, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Mar 24, 2017
@mscdex
Copy link
Contributor

mscdex commented Mar 24, 2017

This commit's message should use the test: prefix instead.

@rjbernaldo
test: add second argument to assert.throws()
129ae01 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
@rjbernaldo rjbernaldo force-pushed the first-commit-fix-test branch from cc929cb to 129ae01 Compare March 24, 2017 08:28
@rjbernaldo rjbernaldo changed the title util: add second argument to assert.throws() test test: add second argument to assert.throws() Mar 24, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Mar 24, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7016/

Trott
Trott approved these changes Mar 24, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure is unrelated.

@fhinkel
Copy link
Member

fhinkel commented Mar 26, 2017

Landed in 1377d5a

@fhinkel fhinkel closed this Mar 26, 2017
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
@rjbernaldo @fhinkel
test: add second argument to assert.throws()
1377d5a 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@rjbernaldo @MylesBorins
test: add second argument to assert.throws()
a73dea9 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@rjbernaldo @MylesBorins
test: add second argument to assert.throws()
b73b761 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@rjbernaldo @MylesBorins
test: add second argument to assert.throws()
fcc19e1 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@rjbernaldo @andrew749
test: add second argument to assert.throws()
9c7840a 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: nodejs/node#12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.