doc: add supported platforms list #11872

mhdawson · 2017-03-15T22:16:30Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

Talked to Rod, going to take over landing the supported platform list from him. Earlier review/discussion was in: d883278

vsemozhetbyt · 2017-03-15T22:30:25Z

BUILDING.md

+
+### Shared libraries & dependencies
+
+Node.js intends to support building against shared representations of dependencies found in the [*deps*][./deps/] directory.


[*deps*](./deps/) ?

targos · 2017-03-16T06:25:39Z

BUILDING.md

+| GNU/Linux    | Tier 1       | kernel >= 2.6.18, glibc >= 2.5   | x86, x64, arm, arm64 |                  | 
+| macOS        | Tier 1       | >= 10.10                         | x64                  |                  |
+| Windows      | Tier 1       | >= Windows 7 or >= Windows2008R2 | x86, x64             |                  |
+| SmartOS      | Tier 2       | >= 14 < 16.4                     | x86, x64             | see note1        |


On master, I think it's >=15

will update

bnoordhuis

Aside: can you wrap lines at 80 columns?

bnoordhuis · 2017-03-16T07:12:09Z

BUILDING.md

+
+#### Unix
+
+* GCC 4.8 or newer


I'd specify this as 4.8.5 per the discussion in #11840 and nodejs/v8#5.

ok, I guess we can then fix up for earlier versions in the backports

Fishrock123 · 2017-03-16T14:51:02Z

BUILDING.md

+
+#### Windows
+
+* Building Node: Visual Studio 2015¹ or Visual C++ Build Tools 2015 or newer


where is this <sup>1</sup> trying to link to?

nowhere that I can find, will remove.

mhdawson · 2017-03-16T22:50:35Z

@targos @bnoordhuis @vsemozhetbyt @Fishrock123 addressed initial set of commments.

@bnoordhuis I wrapped at 80 were I thought that would work. I'm guessing it won't for the table although I did not have time today to try that. Do you believe that should be able to be wrapped as well and not mess up the table formatting ?

jasnell · 2017-03-16T23:00:12Z

Needs a quick rebase

bnoordhuis · 2017-03-17T14:45:09Z

BUILDING.md

+### Shared libraries & dependencies
+
+Node.js intends to support building against shared representations of
+dependencies found in the [*deps*](./deps/) directory.


I'd leave this out. With c-ares it was broken for years. The numerous V8 patches we float basically mean it's only guaranteed to work with our fork.

Historically, we made no promises except that we'll consider patches.

I'll remove for now, and we can add back in through follow PRs if appropriate after more discussion. What I think makes sense is that once this PR lands, I can open a new one adding that back in and we can have the discussion there as opposed to blocking getting the reset of the info in.

bnoordhuis · 2017-03-17T14:45:53Z

@mhdawson Leaving the table unchanged is fine.

gibfahn · 2017-03-17T14:51:17Z

@mhdawson I see that the original PR was targeting v6, should the target branch of this one be changed to v6, or is it the supported platforms list for Node 8 (or Node 9, as there's already a v8.x branch)?

The other question is how this will be updated, is the plan to make sure a commit lands revising it before each major release of Node?

mhdawson · 2017-03-17T21:22:33Z

@gibfahn my plan is to land this for master as a base and then submit PRs to the other branches which reflect what is supported for those levels.

In terms of new releases, I think we should try to keep it up to date generally but definitely make sure it is updated to just before each major release of Node.

mhdawson · 2017-03-17T21:37:42Z

Ok rebased, and addressed @bnoordhuis comment.

gibfahn

LGTM, this has been open since October, let's land it.

bnoordhuis · 2017-03-17T22:06:43Z

BUILDING.md

+#### Windows
+
+* Building Node: Visual Studio 2015 or Visual C++ Build Tools 2015 or newer
+* Building native add-ons: Visual Studio 2013 or Visual C++ Build Tools 2015 or newer


mhdawson · 2017-03-20T17:01:17Z

Ok fixed long line, will now land.

mhdawson · 2017-03-20T17:04:25Z

CI run, to be safe

CI: https://ci.nodejs.org/job/node-test-pull-request/6935/

PR-URL: #11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

mhdawson · 2017-03-20T17:49:42Z

Landed as ef47687.

Next steps

Submit PR for part about supporting deps for additional discussion
Submit PRs for 6.X and 4.X as backport/tweak to be appropriate for those levels

- In the review of nodejs#11872 we pulled out the discussion of supporting dependencies. This PR adds back that statement. - Update README.md to indicatte BUILDING.md contains the list of supported platforms.

mhdawson · 2017-03-20T18:52:14Z

PR for discussion around what we should say about supporting dependencies: #11942

thefourtheye · 2017-03-20T19:25:45Z

Closing this PR as the commit has landed in ef47687

mhdawson · 2017-03-20T19:50:02Z

PR to add supported platform list to 6.X - #11943

PR-URL: nodejs#11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Original Commit Message: PR-URL: #11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Backport-Of: #11872 PR-URL: #11943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Original Commit Message: PR-URL: nodejs#11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Backport-Of: nodejs#11872 PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Original Commit Message: PR-URL: #11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Backport-Of: #11872 PR-URL: #11943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Original Commit Message: PR-URL: nodejs/node#11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Backport-Of: nodejs/node#11872 PR-URL: nodejs/node#11943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

mhdawson self-assigned this Mar 15, 2017

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 15, 2017

vsemozhetbyt reviewed Mar 15, 2017

View reviewed changes

jasnell approved these changes Mar 15, 2017

View reviewed changes

Trott approved these changes Mar 16, 2017

View reviewed changes

silverwind approved these changes Mar 16, 2017

View reviewed changes

targos reviewed Mar 16, 2017

View reviewed changes

bnoordhuis requested changes Mar 16, 2017

View reviewed changes

Fishrock123 reviewed Mar 16, 2017

View reviewed changes

bnoordhuis requested changes Mar 17, 2017

View reviewed changes

doc: add supported platforms list

802344e

mhdawson force-pushed the docsupport branch from 07cbb1d to 802344e Compare March 17, 2017 21:37

gibfahn reviewed Mar 17, 2017

View reviewed changes

gibfahn approved these changes Mar 17, 2017

View reviewed changes

bnoordhuis approved these changes Mar 17, 2017

View reviewed changes

squash: address comments

5e94c0a

italoacasas added dont-land-on-v4.x labels Mar 20, 2017

mhdawson mentioned this pull request Mar 20, 2017

doc: add statement about support for dependencies #11942

Closed

3 tasks

thefourtheye closed this Mar 20, 2017

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

refack mentioned this pull request Apr 9, 2017

doc: update os.uptime() and process.uptime() descriptions #12294

Closed

2 tasks

mhdawson deleted the docsupport branch June 28, 2017 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: add supported platforms list #11872

doc: add supported platforms list #11872

mhdawson commented Mar 15, 2017

vsemozhetbyt Mar 15, 2017

mhdawson Mar 16, 2017

targos Mar 16, 2017

mhdawson Mar 16, 2017

bnoordhuis left a comment

bnoordhuis Mar 16, 2017

mhdawson Mar 16, 2017

Fishrock123 Mar 16, 2017

mhdawson Mar 16, 2017

mhdawson commented Mar 16, 2017

jasnell commented Mar 16, 2017

bnoordhuis Mar 17, 2017

mhdawson Mar 17, 2017

bnoordhuis commented Mar 17, 2017

gibfahn commented Mar 17, 2017

mhdawson commented Mar 17, 2017 •

edited

Loading

mhdawson commented Mar 17, 2017

gibfahn left a comment

bnoordhuis Mar 17, 2017

mhdawson commented Mar 20, 2017

mhdawson commented Mar 20, 2017

mhdawson commented Mar 20, 2017

mhdawson commented Mar 20, 2017

thefourtheye commented Mar 20, 2017

mhdawson commented Mar 20, 2017


		### Shared libraries & dependencies

		Node.js intends to support building against shared representations of dependencies found in the [deps][./deps/] directory.


		#### Windows

		* Building Node: Visual Studio 2015¹ or Visual C++ Build Tools 2015 or newer

doc: add supported platforms list #11872

doc: add supported platforms list #11872

Conversation

mhdawson commented Mar 15, 2017

Checklist

Affected core subsystem(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnoordhuis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhdawson commented Mar 16, 2017

jasnell commented Mar 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnoordhuis commented Mar 17, 2017

gibfahn commented Mar 17, 2017

mhdawson commented Mar 17, 2017 • edited Loading

mhdawson commented Mar 17, 2017

gibfahn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhdawson commented Mar 20, 2017

mhdawson commented Mar 20, 2017

mhdawson commented Mar 20, 2017

mhdawson commented Mar 20, 2017

thefourtheye commented Mar 20, 2017

mhdawson commented Mar 20, 2017

mhdawson commented Mar 17, 2017 •

edited

Loading