Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reduce font size on smaller screens #11695

Closed
wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 5, 2017

The font size for tablet sized screens (or half a laptop screen) is overly
large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

The font size for tablet sized screens (or half a laptop screen) is overly
large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 5, 2017
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my iPhone 5

@silverwind
Copy link
Contributor

cc @Fishrock123.

@silverwind
Copy link
Contributor

@gibfahn can you show some comparision screenshots?

@Fishrock123
Copy link
Contributor

I'm not exactly up-to-date on media queries, aren't some cellphones in this range? I'm not sure if there is other fancy new detection we can do?

@silverwind
Copy link
Contributor

silverwind commented Mar 6, 2017

According to http://mydevice.io/devices/, the highest phone CSS width is 504px in portrait and 768px in landscape mode, so I'd say it's pretty good as-is.

@fhinkel
Copy link
Member

fhinkel commented Mar 9, 2017

Thanks. Landed in 7c8bbe3.

@fhinkel fhinkel closed this Mar 9, 2017
fhinkel pushed a commit that referenced this pull request Mar 9, 2017
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: #11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@gibfahn gibfahn deleted the doc-font branch March 9, 2017 10:11
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: nodejs#11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: nodejs#11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: #11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: #11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: nodejs/node#11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@octref
Copy link

octref commented Aug 17, 2017

How it looks like today:

image

Apparently the issue hasn't been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants