Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, url: turn on WPT tests on empty params pairs #11369

Closed
wants to merge 1 commit into from
Closed

test, url: turn on WPT tests on empty params pairs #11369

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This is fixed by #11234. This PR turns on the tests accordingly.

Refs: #11234

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url-whatwg, test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2017
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 14, 2017
@TimothyGu
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6399/

TimothyGu
TimothyGu approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green (except for ARM but the error looks unrelated). LGTM.

@TimothyGu
Copy link
Member

Landed in 82ddf96.

@TimothyGu TimothyGu closed this Feb 17, 2017
TimothyGu pushed a commit that referenced this pull request Feb 17, 2017
@joyeecheung @TimothyGu
test: turn on WPT tests on empty param pairs
82ddf96 
This specific bug was fixed by #11234. This commit turns on the tests
accordingly.

PR-URL: #11369
Ref: #11234
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @TimothyGu @jasnell @cjihrig @italoacasas @gibfahn @nodejs-github-bot