Skip to content

doc: update email and add personal pronoun #11318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: update email and add personal pronoun #11318

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

Refs: #11089 (comment)

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 12, 2017
jasnell
jasnell approved these changes Feb 12, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to wait the 48 to land

@JungMinu
Copy link
Member Author

Thanks, landed in 87df7e6

@JungMinu JungMinu closed this Feb 13, 2017
@JungMinu JungMinu deleted the add-personal-pronoun-option branch February 13, 2017 02:26
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@JungMinu
doc: update email and add personal pronoun
3db54c9 
Refs: nodejs#11089 (comment)
PR-URL: nodejs#11318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@italoacasas italoacasas mentioned this pull request Feb 14, 2017
Merged
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@JungMinu @krydos
doc: update email and add personal pronoun
089a411 
Refs: nodejs#11089 (comment)
PR-URL: nodejs#11318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@JungMinu @jasnell
doc: update email and add personal pronoun
7a1d236 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@JungMinu @jasnell
doc: update email and add personal pronoun
0d180e0 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@JungMinu @MylesBorins
doc: update email and add personal pronoun
c79d9f9 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@JungMinu @MylesBorins
doc: update email and add personal pronoun
6f1db35 
Refs: #11089 (comment)
PR-URL: #11318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+2 more reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JungMinu @jasnell @thefourtheye @lpinca @targos @joyeecheung @gibfahn @nodejs-github-bot