-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: replace newlines in deprecation with space #11074
Closed
thefourtheye
wants to merge
1
commit into
nodejs:master
from
thefourtheye:doc-fix-multiline-deprecation
Closed
doc: replace newlines in deprecation with space #11074
thefourtheye
wants to merge
1
commit into
nodejs:master
from
thefourtheye:doc-fix-multiline-deprecation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line.
nodejs-github-bot
added
tools
Issues and PRs related to the tools directory.
lts-watch-v6.x
labels
Jan 30, 2017
addaleax
approved these changes
Jan 30, 2017
Fishrock123
approved these changes
Jan 30, 2017
cjihrig
approved these changes
Jan 30, 2017
TimothyGu
approved these changes
Jan 31, 2017
jasnell
approved these changes
Jan 31, 2017
lpinca
approved these changes
Jan 31, 2017
targos
approved these changes
Jan 31, 2017
Landed in 63f110a |
thefourtheye
added a commit
that referenced
this pull request
Feb 1, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: #11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 2, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: nodejs#11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2 tasks
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: nodejs#11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Feb 5, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Feb 6, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: #11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 6, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: #11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: nodejs#11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2017
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: #11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
As it is, each line in the deprecation heading which are wrapped at 80 characters in the *.md files, are shown in different lines. For example > Stability: 0 - Deprecated: Use > `Buffer.from(arrayBuffer[, byteOffset [, length]])` > instead. is shown in three different lines. This patch replaces the newlines with space characters, so that the output will be in single line. PR-URL: nodejs/node#11074 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is, each line in the deprecation heading which are wrapped at 80
characters in the *.md files, are shown in different lines. For example
is shown in three different lines. This patch replaces the newlines
with space characters, so that the output will be in single line.
Before this patch:
https://nodejs.org/api/buffer.html#buffer_new_buffer_arraybuffer_byteoffset_length
After this patch:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
tools
cc @nodejs/documentation