Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add path.join's test #11063

Closed
wants to merge 1 commit into from
Closed

test: add path.join's test #11063

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 29, 2017 •
edited
Loading

Add a test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and Array.from.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@hiroppy
test: add path.join's test
adb1b8a 
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 29, 2017
@mscdex mscdex added the path Issues and PRs related to the path subsystem. label Jan 29, 2017
@jasnell
Copy link
Member

jasnell commented Jan 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6110/

hiroppy added a commit that referenced this pull request Feb 2, 2017
@hiroppy
test: add path.join's test
81d1559 
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: #11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@hiroppy
Copy link
Member Author

hiroppy commented Feb 2, 2017

Landed in 81d1559.

@hiroppy hiroppy closed this Feb 2, 2017
@hiroppy hiroppy deleted the feature/test-path branch February 2, 2017 00:43
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 2, 2017
@hiroppy @italoacasas
test: add path.join's test
d103088 
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: nodejs#11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 5, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@hiroppy @italoacasas
test: add path.join's test
ea5bef5 
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: nodejs#11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@hiroppy @jasnell
test: add path.join's test
e6b2ddd 
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: #11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

would require a backport PR in order to land on v4 (if it should at all)

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@hiroppy @MylesBorins
test: add path.join's test
87488ba 
Add test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and `Array.from`.

PR-URL: #11063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
path Issues and PRs related to the path subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hiroppy @jasnell @addaleax @lpinca @mscdex @nodejs-github-bot