test: add an exception test to http-write-head#11034
Closed
hiroppy wants to merge 1 commit intonodejs:masterfrom
Closed
test: add an exception test to http-write-head#11034hiroppy wants to merge 1 commit intonodejs:masterfrom
hiroppy wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Jan 27, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but this could use some common.mustCall() in several places while you're in here.
hiroppy
force-pushed
the
feature/test-http-write-head
branch
from
e3f0c7d to
485dac5
Compare
jasnell
approved these changes
Jan 27, 2017
Member
Author
|
Changed to use |
lpinca
approved these changes
Jan 28, 2017
Contributor
|
You could also add |
Add an exception test. Add `common.mustCall()`. Make use of Arrow function. a
hiroppy
force-pushed
the
feature/test-http-write-head
branch
from
485dac5 to
2ec24e0
Compare
Member
Author
|
Added |
cjihrig
approved these changes
Jan 30, 2017
jasnell
pushed a commit
that referenced
this pull request
Jan 30, 2017
* Add an exception test. * Add `common.mustCall()`. * Make use of Arrow function. PR-URL: #11034 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 49e5f61 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
* Add an exception test. * Add `common.mustCall()`. * Make use of Arrow function. PR-URL: #11034 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Add an exception test. * Add `common.mustCall()`. * Make use of Arrow function. PR-URL: #11034 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Test fails in v4, will need a backport PR if it is to land there. Landed in v6 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* Add an exception test. * Add `common.mustCall()`. * Make use of Arrow function. PR-URL: #11034 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an exception test.
Make use of Arrow function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test