- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.7k
 
doc: DEFAULT_ECDH_CURVE was added in 0.11.13 #10983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            sam-github
  merged 0 commits into
  nodejs:master
from
sam-github:doc-when-ecdh-curve-added
  
      
      
   
  Jan 25, 2017 
      
    
                
     Merged
            
            doc: DEFAULT_ECDH_CURVE was added in 0.11.13 #10983
                    sam-github
  merged 0 commits into
  nodejs:master
from
sam-github:doc-when-ecdh-curve-added
  
      
      
   
  Jan 25, 2017 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    68e55f9    to
    ce41f82      
    Compare
  
    | 
           @jasnell maybe I can land this right away with a couple thumbs ups?  | 
    
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Jan 24, 2017 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Landing quickly is probably fine.
              
                    gibfahn
  
              
              approved these changes
              
                  
                    Jan 25, 2017 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Jan 25, 2017 
                  
              
              
            
            
ce41f82    to
    124d155      
    Compare
  
    
    
  italoacasas 
      pushed a commit
        to italoacasas/node
      that referenced
      this pull request
    
      Jan 26, 2017 
    
    
      
  
    
      
    
  
Document this with the YAML meta-data. PR-URL: nodejs#10983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    
  italoacasas 
      pushed a commit
        to italoacasas/node
      that referenced
      this pull request
    
      Jan 27, 2017 
    
    
      
  
    
      
    
  
Document this with the YAML meta-data. PR-URL: nodejs#10983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
      
     Merged
  
    
  italoacasas 
      pushed a commit
        to italoacasas/node
      that referenced
      this pull request
    
      Jan 30, 2017 
    
    
      
  
    
      
    
  
Document this with the YAML meta-data. PR-URL: nodejs#10983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    
  italoacasas 
      pushed a commit
        to italoacasas/node
      that referenced
      this pull request
    
      Jan 30, 2017 
    
    
      
  
    
      
    
  
Document this with the YAML meta-data. PR-URL: nodejs#10983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Mar 8, 2017 
    
    
      
  
    
      
    
  
Document this with the YAML meta-data. PR-URL: #10983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Mar 9, 2017 
    
    
      
  
    
      
    
  
Document this with the YAML meta-data. PR-URL: #10983 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Checklist
Affected core subsystem(s)
doc,tls