Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve code in test-http-host-headers #10830

Closed
wants to merge 1 commit into from
Closed

test: improve code in test-http-host-headers #10830

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 16, 2017

  • use common.fail to handle errors
  • remove console.log
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@edsadr
test: improve code in test-http-host-headers
f8544a3 
* use common.fail to handle errors
* remove console.log
* use arrow functions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 16, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Jan 16, 2017
@mscdex
Copy link
Contributor

mscdex commented Jan 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5878/

jasnell pushed a commit that referenced this pull request Jan 16, 2017
@edsadr @jasnell
test: improve code in test-http-host-headers
f4fd073 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: #10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 16, 2017

Landed in f4fd073

@jasnell jasnell closed this Jan 16, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr @italoacasas
test: improve code in test-http-host-headers
2f3bdfb 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: nodejs#10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 28, 2017
@edsadr @targos
test: improve code in test-http-host-headers
afcc56b 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: #10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr @italoacasas
test: improve code in test-http-host-headers
7f04377 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: nodejs#10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr @italoacasas
test: improve code in test-http-host-headers
bdf3d7d 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: nodejs#10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr @jasnell
test: improve code in test-http-host-headers
9f5a905 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: #10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr @jasnell
test: improve code in test-http-host-headers
65b7200 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: #10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr @MylesBorins
test: improve code in test-http-host-headers
76f0556 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: #10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr @MylesBorins
test: improve code in test-http-host-headers
9ac2316 
* use common.fail to handle errors
* remove console.log
* use arrow functions

PR-URL: #10830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edsadr @mscdex @jasnell @lpinca @cjihrig @targos @nodejs-github-bot