Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update coverage for dgram.js #10783

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/parallel/test-dgram-multicast-loopback.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const socket = dgram.createSocket('udp4');

socket.bind(0);
socket.on('listening', common.mustCall(() => {
const result = socket.setMulticastLoopback(16);
assert.strictEqual(result, 16);
socket.close();
}));
20 changes: 10 additions & 10 deletions test/parallel/test-dgram-multicast-setTTL.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const socket = dgram.createSocket('udp4');
let thrown = false;

socket.bind(0);
socket.on('listening', function() {
socket.setMulticastTTL(16);
socket.on('listening', common.mustCall(() => {
const result = socket.setMulticastTTL(16);
assert.strictEqual(result, 16);

//Try to set an invalid TTL (valid ttl is > 0 and < 256)
try {
assert.throws(() => {
socket.setMulticastTTL(1000);
} catch (e) {
thrown = true;
}
}, /^Error: setMulticastTTL EINVAL$/);

assert(thrown, 'Setting an invalid multicast TTL should throw some error');
assert.throws(() => {
socket.setMulticastTTL('foo');
}, /^TypeError: Argument must be a number$/);

//close the socket
socket.close();
});
}));
15 changes: 10 additions & 5 deletions test/parallel/test-dgram-setTTL.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const socket = dgram.createSocket('udp4');

socket.bind(0);
socket.on('listening', function() {
socket.on('listening', common.mustCall(() => {
const result = socket.setTTL(16);
assert.strictEqual(result, 16);

assert.throws(function() {
assert.throws(() => {
socket.setTTL('foo');
}, /Argument must be a number/);
}, /^TypeError: Argument must be a number$/);

// TTL must be a number from > 0 to < 256
assert.throws(() => {
socket.setTTL(1000);
}, /^Error: setTTL EINVAL$/);

socket.close();
});
}));