test: refactor the code in test/pummel/test-child-process-spawn-loop.js#10605
Closed
sivaprs wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor the code in test/pummel/test-child-process-spawn-loop.js#10605sivaprs wants to merge 1 commit intonodejs:masterfrom
sivaprs wants to merge 1 commit intonodejs:masterfrom
Conversation
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions
nodejs-github-bot
added
test
Contributor
Author
|
cc: @thefourtheye |
mscdex
added
the
child_process
thefourtheye
reviewed
Jan 4, 2017
| function doSpawn(i) { | ||
| var child = spawn('python', ['-c', 'print ' + SIZE + ' * "C"']); | ||
| var count = 0; | ||
| const child = spawn('python', ['-c', 'print ' + SIZE + ' * "C"']); |
Contributor
There was a problem hiding this comment.
@nodejs/testing This test depends on python, although I understand that our build system depends on it. Is that okay to keep it as it is, or refactor it?
Member
There was a problem hiding this comment.
I think it's reasonable to keep the dependency here but it's also reasonable to spawn Node instead. I don't want to block this PR on it though.
benjamingr
approved these changes
Jan 4, 2017
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Changes LGTM but I'm still +0 on such PRs.
Member
jasnell
approved these changes
Jan 9, 2017
jasnell
pushed a commit
that referenced
this pull request
Jan 9, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 41567ee |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10605 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
change description: