Skip to content

url: fix URL query update if searchParams changes #10486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2017
Merged

url: fix URL query update if searchParams changes #10486

merged 1 commit into from
Jan 1, 2017

Conversation

@targos
Copy link
Member

@targos targos commented Dec 28, 2016

If searchParams becomes empty, query must be set to null.
Add missing update of context flags.

Fixes: #10480

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Dec 28, 2016
@targos targos mentioned this pull request Dec 28, 2016
Closed
@targos targos requested a review from jasnell December 28, 2016 09:19
@targos
Copy link
Member Author

targos commented Dec 31, 2016

/cc @jasnell

@targos
url: fix URL query update if searchParams changes
b465cd0 
If searchParams becomes empty, query must be set to null.
Add missing update of context flags.

Fixes: nodejs#10480
PR-URL: nodejs#10486
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos merged commit b465cd0 into nodejs:master Jan 1, 2017
@targos
Copy link
Member Author

targos commented Jan 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5654/

@gibfahn
Copy link
Member

gibfahn commented Jan 1, 2017

@nodejs/punished ? 😉

@targos
Copy link
Member Author

targos commented Jan 1, 2017

Landed in b465cd0
😊

@targos targos deleted the fix-10480 branch January 1, 2017 16:40
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@targos @evanlucas
url: fix URL query update if searchParams changes
c66870b 
If searchParams becomes empty, query must be set to null.
Add missing update of context flags.

Fixes: #10480
PR-URL: #10486
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@targos @evanlucas
url: fix URL query update if searchParams changes
6977224 
If searchParams becomes empty, query must be set to null.
Add missing update of context flags.

Fixes: #10480
PR-URL: #10486
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos @gibfahn @jasnell @nodejs-github-bot