Skip to content

doc,src: clarify doc/comment about ABI number #10419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc,src: clarify doc/comment about ABI number #10419

wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Dec 23, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc src process

Description of change

@Trott Trott added doc Issues and PRs related to the documentations. lib / src Issues and PRs related to general changes in the lib or src directory. process Issues and PRs related to the process subsystem. labels Dec 23, 2016
@Trott
Copy link
Member Author

Trott commented Dec 23, 2016

Refs: #9901 (comment)

@Trott
Copy link
Member Author

Trott commented Dec 23, 2016

R=@addaleax @sam-github

@Trott Trott force-pushed the process.versions.module branch from 2d92efc to 67e8a65 Compare December 23, 2016 01:44
@Trott Trott requested review from addaleax and sam-github December 23, 2016 01:45
@Trott
Copy link
Member Author

Trott commented Dec 23, 2016

Whoops, looks like this will conflict with #10414. I'll remove the change to node_version.h in this PR and defer to the version in that PR. This will still update the doc file.

@Trott Trott force-pushed the process.versions.module branch from 67e8a65 to 26894b9 Compare December 23, 2016 02:05
@Trott Trott mentioned this pull request Dec 23, 2016
Closed
1 task
@Trott Trott force-pushed the process.versions.module branch from 26894b9 to 15c72c3 Compare December 24, 2016 17:57
@Trott Trott removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 24, 2016
@Trott
Copy link
Member Author

Trott commented Dec 26, 2016

@nodejs/documentation

@Trott Trott force-pushed the process.versions.module branch from 15c72c3 to 89906ed Compare December 28, 2016 04:22
@Trott
Copy link
Member Author

Trott commented Dec 28, 2016

Bump! I think this is ready to land if anyone wants to read it. Should be a rather quick review...

@Trott Trott force-pushed the process.versions.module branch from 89906ed to 3c10feb Compare December 28, 2016 04:25
thefourtheye
thefourtheye approved these changes Dec 28, 2016
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to remove comment from the commit title

@Trott Trott force-pushed the process.versions.module branch from 3c10feb to 6755347 Compare December 28, 2016 17:00
Trott added a commit to Trott/io.js that referenced this pull request Dec 28, 2016
@Trott
doc: clarify information about ABI version
1b2d3f7 
PR-URL: nodejs#10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: nodejs#9901 (comment)
@Trott
Copy link
Member Author

Trott commented Dec 28, 2016

Landed in 1b2d3f7

@Trott Trott closed this Dec 28, 2016
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@Trott
doc: clarify information about ABI version
08a0779 
PR-URL: nodejs#10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: nodejs#9901 (comment)
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@Trott
doc: clarify information about ABI version
b7cf821 
PR-URL: nodejs#10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: nodejs#9901 (comment)
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@Trott
doc: clarify information about ABI version
3a26dc5 
PR-URL: nodejs#10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: nodejs#9901 (comment)
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@Trott
doc: clarify information about ABI version
3270d4c 
PR-URL: nodejs#10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: nodejs#9901 (comment)
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
@Trott @MylesBorins
doc: clarify information about ABI version
edb1615 
PR-URL: #10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: #9901 (comment)
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
doc: clarify information about ABI version
0a1d15f 
PR-URL: #10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: #9901 (comment)
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott Trott deleted the process.versions.module branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@sam-github sam-github Awaiting requested review from sam-github

+1 more reviewer

@thefourtheye thefourtheye thefourtheye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @jasnell @thefourtheye @targos @mscdex @MylesBorins @nodejs-github-bot