test: fix failing test-fs-access while uid 0 #1037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superusers can open files with W_OK permission even though their mode is set to 0444. Patch originally from nodejs/node-v0.x-archive@28d0cbbd. Fixes nodejs#1031. PR-Url: nodejs#1031
cjihrig
pushed a commit
that referenced
this pull request
Mar 3, 2015
Superusers can open files with W_OK permission even though their mode is set to 0444. This commit makes the test attempt to change its uid to nobody on non-Windows platforms. Patch originally from nodejs/node-v0.x-archive@28d0cbbd. Fixes: #1031 PR-URL: #1037 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks. Landed in fd3ea29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superusers can open files with W_OK permission even though their mode is set to 0444. Patch originally from nodejs/node-v0.x-archive@28d0cbbd.
Fixes #1031.
/R=@cjihrig