src, lib: deprecate old debug-agent and CLI debugger #10276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print a warning if --debug or debug are used on the command line. PR-URL: <tbd> Reviewed-By: <tbd> Reviewed-By: <tbd>
joshgav
added
debugger
lib / src
nodejs-github-bot
added
c++
|
Do we want to just pull in the soft deprecation (doc update) into this PR as well or is that taken care of in another place? |
9 tasks
I'd be inclined to put that in as a separate PR so that it doesn't get held up in case there are issues with a runtime deprecation. Is anyone stepping up to do the doc deprecation? I guess it would just be a note in |
2 tasks
|
Since I couldn't find a PR that does it yet: #10320 |
jasnell
requested changes
Dec 23, 2016
| @@ -27,6 +27,7 @@ exports.start = function(argv, stdin, stdout) { | |||
| stdout = stdout || process.stdout; | |||
|
|
|||
| const args = [`--debug-brk=${exports.port}`].concat(argv); | |||
| console.error('`node debug` is deprecated, use `node inspect` instead.\n'); | |||
There was a problem hiding this comment.
If possible, this should be updated to use process.emitWarning() and DeprecationWarning instead.
jasnell
added
the
semver-major
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src, debugger
Description of change
Per #9789 the old V8 debugger and its protocol are on their way out 👋 .
This prints a deprecation warning to stderr when node is invoked with
--debugordebug.--debugstarts the debug-agent within the process;debugstarts Node's builtin CLI debugger. Both utilize the old V8 debugger protocol.V8 inspector and
--inspectreplace--debug. Work is underway to replace the CLI debugger (i.e.node debug), see #10187.I didn't use
util.deprecateon the_debugger.start()function because it would print within the repl, i.e. prefixed withdebug>./cc @nodejs/diagnostics