-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add stdin-setrawmode.out file to accompany test #10146
test: add stdin-setrawmode.out file to accompany test #10146
Conversation
Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at nodejs#10037.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Very strange, it's passing on my machine. Doing a full rebuild now in an effort to get it failing locally. |
Hmm, looks like this is popping up on some platforms: |
Are you running it through the test runner, or are you just executing the file? You will want to execute |
The test passes fine for me now on OS X 10.10.5 |
I'm running it with Unfortunately, it's still passing for me after a fresh build using both |
Yeah, sorry, my bad. Inside of CI, stdin is currently not a TTY, even for the pseudo-tty tests… sigh |
marking |
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test
Description of change
Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js.
The test was originally merged without this file and an astute
observer found that it was causing an error message. See discussion
at #10037.