Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-dgram-msgsize.js #10032

Closed
wants to merge 1 commit into from
Closed

test: refactor test-dgram-msgsize.js #10032

wants to merge 1 commit into from

Conversation

dguo
Copy link
Contributor

@dguo dguo commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Change var to const, and change assert.equal() to assert.strictEqual().

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. labels Dec 1, 2016
@mcollina
Copy link
Member

mcollina commented Dec 6, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5229/

@mcollina
Copy link
Member

mcollina commented Dec 6, 2016

Failure unrelated. Merging.

@mcollina
Copy link
Member

mcollina commented Dec 6, 2016

Impossible to merge, the same changes are part of #9926.

@mcollina mcollina closed this Dec 6, 2016
@Trott
Copy link
Member

Trott commented Dec 7, 2016

Sorry about giving you a duplicate task! I see that you got a few other PRs open from Code & Learn, so that's a relief. :-D

Anyway, this was my mistake, so I apologize!

@dguo
Copy link
Contributor Author

dguo commented Dec 7, 2016

Oh, it's no problem. Thanks for MCing the event! It was fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dguo @mcollina @Trott @jasnell @cjihrig @imyller @nodejs-github-bot