Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA, DH, ECDH computation failures due to CVE-2016-7055 on the Intel CPU of Broadwell or later #9594

Closed
shigeki opened this issue Nov 13, 2016 · 2 comments
Labels
crypto Issues and PRs related to the crypto subsystem. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

  • Version: 7.x, 6.x and 4.x
  • Platform: all
  • Subsystem: crypto

As for recent openssl-1.1.0 security advisory in https://www.openssl.org/news/secadv/20161110.txt,
"Montgomery multiplication may produce incorrect results (CVE-2016-7055)" is also affect openssl-1.0.2 and it is scored as low severity.

It is already fixed in the current 1.0.2 branch as openssl/openssl@57c4b9f but it is not released yet due to its low severity.

The original issue report is openssl/openssl#1774 and Node is affected in RSA, DH and ECDH computing in the crypto module when Intel CPU later than Browdwell is used. We confirmed that a RSA encryption/decryption failure in Node by using the reported data on Skylake. The failure depends on its crypto parameters, data and CPU but we don't know how much users are affected.

The release date of new openssl-1.0.2k is not yet announced. If it is reported that some of users are affected to this issue, we can fix it by applying a floating patch before the official release of openssl.

@addaleax addaleax added the openssl Issues and PRs related to the OpenSSL dependency. label Nov 13, 2016
@shigeki shigeki added the crypto Issues and PRs related to the crypto subsystem. label Nov 13, 2016
@shigeki
Copy link
Contributor Author

shigeki commented Jan 26, 2017

Resolved in #11021

@shigeki shigeki closed this as completed Jan 26, 2017
@vejo
Copy link

vejo commented Apr 26, 2017

We ran into a SSL problem on an Intel Celeron N3350, even with the latest nodejs versions (v7.9.0, v4.8.2, v6.10.2), which might be caused by an invalid mac calculation.
Is this fix already active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

No branches or pull requests

3 participants