-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Closed
Labels
lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Description
To avoid discussions and diffs like https://github.com/nodejs/node/pull/9379/files#r85787597, we could enable EditorConfig's option to enforce a final newline:
insert_final_newline = true
For js files, this could additionally be enforced through the eol-last linter rule. If we decide to do it, we need to assert which files we want to include in .editorconfig. I think anything except deps and likely test assets should be good.
sam-github, cjihrig, lpinca, thefourtheye and danjesus
Metadata
Metadata
Assignees
Labels
lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.