Skip to content

Consistent trailing newlines #9402

Closed
Closed
@silverwind

Description

@silverwind

To avoid discussions and diffs like https://github.com/nodejs/node/pull/9379/files#r85787597, we could enable EditorConfig's option to enforce a final newline:

insert_final_newline = true

For js files, this could additionally be enforced through the eol-last linter rule. If we decide to do it, we need to assert which files we want to include in .editorconfig. I think anything except deps and likely test assets should be good.

cc: @thefourtheye @addaleax @cjihrig @princejwesley @lpinca

Metadata

Metadata

Assignees

No one assigned

    Labels

    lib / srcIssues and PRs related to general changes in the lib or src directory.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions