Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream, test: Add test for _writableState clearBuffer state machine #8687

Closed
mcollina opened this issue Sep 21, 2016 · 1 comment
Closed

stream, test: Add test for _writableState clearBuffer state machine #8687

mcollina opened this issue Sep 21, 2016 · 1 comment
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Comments

@mcollina
Copy link
Member

  • Version: all
  • Platform: all
  • Subsystem: stream, test

Part of #8644

Add tests for:

stream._writableState.corked
stream._writableState.bufferedRequestCount

node/lib/_stream_writable.js

Line 376 in 774146d

function clearBuffer(stream, state) {

node/lib/_stream_writable.js

Lines 73 to 74 in 774146d

// when true all writes will be buffered until .uncork() call
this.corked = 0;

node/lib/_stream_writable.js

Lines 112 to 113 in 774146d

// count buffered requests
this.bufferedRequestCount = 0;

cc @Fishrock123 @nodejs/streams
@mcollina mcollina added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. good first issue Issues that are suitable for first-time contributors. labels Sep 21, 2016
@a-metta
Copy link
Contributor

a-metta commented Sep 24, 2016 •
edited
Loading

@mcollina i'll take a look at this!

@captainsafia captainsafia mentioned this issue Dec 1, 2016
Closed
3 tasks
mcollina pushed a commit to captainsafia/node that referenced this issue Jan 2, 2017
@captainsafia @mcollina
test: add tests for clearBuffer state machine
b0be2ac 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: nodejs#8687
PR-URL: nodejs#9922
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 4, 2017
@captainsafia @evanlucas
test: add tests for clearBuffer state machine
5852336 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
2a74df6 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
7b09f4e 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
c6cb93f 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
00026cf 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
b3b7686 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Jan 31, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
1c6e171 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this issue Feb 1, 2017
@captainsafia @MylesBorins
test: add tests for clearBuffer state machine
1fac431 
This checks to see that clearBuffer appropriately decrements the
correct values in _writableState when clearBuffer is invoked in
end.

Fixes: #8687
PR-URL: #9922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add tests for clearBuffer state machine captainsafia/node
3 participants
@mcollina @a-metta @italoacasas