Release proposal: v1.2.0

[rvagg]

We have to jump straight to 1.2.0 for this because of:

• dns - add 'all' option to dns.lookup #744 / 633a990 (dns: allow dns.lookup() to return all addresses)
• stream: simpler stream constructon #697 / 50daee7 (stream: simpler stream constructon)

One might also argue that this qualifies too:

• assert: don't compare object prototype property #636 / e7573f9 (assert: don't compare object prototype property)

I'm also going to turn on the ARMv6 build slave for releases, it's been churning out nightlies with success but this will be the first proper release that will have Raspberry Pi (and other) compatible binaries!

npm changelog is in #738.

I propose we cut this release within 48 hours.

Full commit log since v1.1.0

• [828d19a] - doc: fix dns.lookup options example (Roman Reiss)
• [90d2b35] - doc: update antiquated process.versions output (Ben Noordhuis)
• [789bbb9] - doc: update node.js references in api docs (Ben Noordhuis)
• [c22e5ac] - https: simpler argument check (Michaël Zasso)
• [b9d3928] - util: simplify isPrimitive (Vladimir Kurchatkin)
• [2c3121c] - benchmark: bump eventemitter number of iterations (Ben Noordhuis)
• [633a990] - dns: allow dns.lookup() to return all addresses (Roman Reiss)
• [1cd1d7a] - buffer: don't compare same buffers (Vladimir Kurchatkin)
• [847b9d2] - benchmark: add more EventEmitter benchmarks (Brian White)
• [96597bc] - doc: add lxe as collaborator (Aleksey Smolenchuk)
• [7a301e2] - deps: make node-gyp work again on windows (Bert Belder)
• [b188a34] - deps: make node-gyp fetch tarballs from iojs.org (Ben Noordhuis)
• [af1bf49] - deps: upgrade npm to 2.5.1 (Forrest L Norvell)
• [9dc9ec3] - lib: make debug client connect to 127.0.0.1 (Ben Noordhuis)
• [e7573f9] - assert: don't compare object prototype property (Vladimir Kurchatkin)
• [8d11799] - asyncwrap: fix nullptr parent check (Trevor Norris)
• [62512bb] - test: accept EPROTONOSUPPORT ipv6 error (Ben Noordhuis)
• [05f4dff] - asyncwrap: fix constructor condition for early ret (Trevor Norris)
• [10277d2] - docs: include mention of new crypto methods (Calvin Metcalf)
• [9a8f186] - child_process: add debug and error details (Zach Bruggeman)
• [6f7a978] - crypto: clear error on return in TLS methods (Fedor Indutny)
• [50daee7] - stream: simpler stream constructon (Sam Newman)
• [e0730ee] - benchmark: allow compare via fine-grained filters (Brian White)
• [96ffcb9] - src: reduce cpu profiler overhead (Ben Noordhuis)
• [3e675e4] - benchmark: don't use template strings (Evan Lucas)
• [8ac8b76] - doc: simplified pure consensus seeking (Mikeal Rogers)
• [0a54b6a] - doc: update streams wg charter (Chris Dickinson)
• [b8ead4a] - Adjusting for feedback in the PR. (Mikeal Rogers)
• [3af7f30] - Initial documentation for working groups. (Mikeal Rogers)
• [513724e] - doc: add GPG fingerprint for chrisdickinson (Chris Dickinson)
• [4168198] - doc: add TC meeting 2015-01-28 minutes (Rod Vagg)

[vkurchatkin]

I also want to land #639

I think we should release a candidate in 24 hours and then release the full release in 48 hours so that people can test and find bugs.

[rvagg]

right, well this is basically a notice to that effect, the next two nightly will be RC1 and the one after that will be RC2 just before a release if everything goes well.

[fengmk2]

How about #493 ? It is depended by nodejs/node-gyp#564

[bnoordhuis]

#760 is a moderately serious regression, albeit not a new one (introduced in v1.0.2) and doesn't need to hold up the release.

[Fishrock123]

Should we get a fix for #708 in? (the original bug for the dns.lookup thing)

[Fishrock123]

Some people in irc wanted to see #758 land in this.

[vkurchatkin]

@Fishrock123 it's far from being done

[petkaantonov]

@vkurchatkin If there is still something to do in the PR, you should say it. I was under the impression that it is now ready.

[benjamingr]

I'm very interested in landing #758 already and it would be great if it was included in 1.2 - I'm also under the impression that it's done. If there are any issues with it please do speak up.

[benjamingr]

@vkurchatkin other than the two "no curly braces for one-line bodies" is there anything else holding back this PR? If those are fixed from your perspective can it be merged?

[vkurchatkin]

@benjamingr I'm very interested in this too, and that is why I think it's important to do it right

[bnoordhuis]

Scanning through the comments, it looks like #758 warrants some further discussion. I'd like to hold off on merging it for now.

[benjamingr]

@vkurchatkin my point is that assuming we don't specify a default handler and don't specify super precise timer control for #758 we can merge it now and improve these later. Merging it now is just introducing two events to process - it's the most minimal change required and it's immensely useful without getting dragged into breaking changes like adding a default action handler which will cause a lot of debate.

I think that tackling these hard questions (default action and more precise scheduling) can and should be deferred to a later point in time while we can still gain the vast majority of the benefit without sacrificing any future compatibility right now. It will also give us time to evaluate how users choose to deal with unhandled rejections.

Also although it's obvious I'd like to point out you've been immensely useful with this - the feedback you've been providing has been very valuable here.