Repository navigation
OpenSSL windows asm question #7426
Description
Activity
For part 2
DebugInformationFormatoption may be used as well.Also,
.asmfiles are supported by GYP since I don't know what time, so there is no reason to have extra rules for them.- added a commit that references this issue
on Jun 26, 2016 Not a Windows compiler/linker expert but I suspect that without
/safesehyou wouldn't be able to link add-ons that depend on SafeSEH.+1 for removing
/Zi, also for all that .pdb files and manifests and some assembly inlining. For some of those flags even the MSDN pages warn for extreme file bloat./SafeSEH: I can only guess, but I assume it predates the current compilation workflow, whereopensslhas been compiled with an older compiler, that didn't include/safesehand we wanted to protect against it. The MSDN page contradicts the commit message, as the flag does not mark afile, but protect against it at compile time. I found this to be useful, when I decided to exclude it. However it should not be expensive to let it in.@indutny, @eljefedelrodeodeljefe: for /safeseh: see nodejs/node-v0.x-archive#4242
I think you can drop /Zi.
@piscisaureus thank you, asked you a question in #7427 ;)
- added a commit that references this issue
on Sep 3, 2016 - added a commit that references this issue
on Sep 4, 2016 - added a commit that references this issue
on Sep 28, 2016 - added a commit that references this issue
on Oct 18, 2016 - added a commit that references this issue
on Oct 26, 2016
Part 1
01fa5ee
What is the purpose of this? cc @piscisaureus
As far as I get it - GYP option may be used to enable this: https://github.com/svn2github/gyp/blob/e0ee72ddc7fb97eb33d530cf684efcbe4d27ecb3/test/win/ml-safeseh/ml-safeseh.gyp#L18-L20
Part 2
What is the purpose of
/Zi? I know that it generates debug info, but can't see why it is needed. cc @piscisaureus againcc @nodejs/collaborators just in case.
Reasoning
I'm thinking about removing
rulesfrom thegyp.jsas I don't really like the feature bloat that it has. It looks like Node builds just fine without these rules