OpenSSL windows asm question

[indutny]

Part 1

01fa5ee

What is the purpose of this? cc @piscisaureus

As far as I get it - GYP option may be used to enable this: https://github.com/svn2github/gyp/blob/e0ee72ddc7fb97eb33d530cf684efcbe4d27ecb3/test/win/ml-safeseh/ml-safeseh.gyp#L18-L20

Part 2

• 7475982#diff-c37979bc7383677eefcd526f4693de15R824

What is the purpose of /Zi? I know that it generates debug info, but can't see why it is needed. cc @piscisaureus again

cc @nodejs/collaborators just in case.

Reasoning

I'm thinking about removing rules from the gyp.js as I don't really like the feature bloat that it has. It looks like Node builds just fine without these rules

[indutny]

For part 2 DebugInformationFormat option may be used as well.

[indutny]

Also, .asm files are supported by GYP since I don't know what time, so there is no reason to have extra rules for them.

[indutny]

Proposed change: #7427

[bnoordhuis]

01fa5ee

Not a Windows compiler/linker expert but I suspect that without /safeseh you wouldn't be able to link add-ons that depend on SafeSEH.

[eljefedelrodeodeljefe]

+1 for removing /Zi, also for all that .pdb files and manifests and some assembly inlining. For some of those flags even the MSDN pages warn for extreme file bloat.

/SafeSEH: I can only guess, but I assume it predates the current compilation workflow, where openssl has been compiled with an older compiler, that didn't include /safeseh and we wanted to protect against it. The MSDN page contradicts the commit message, as the flag does not mark afile, but protect against it at compile time. I found this to be useful, when I decided to exclude it. However it should not be expensive to let it in.

[piscisaureus]

@indutny, @eljefedelrodeodeljefe: for /safeseh: see nodejs/node-v0.x-archive#4242

I think you can drop /Zi.

[indutny]

@piscisaureus thank you, asked you a question in #7427 ;)