Doctool tests require absent eslint

[jellelicht]

• Version: 6.2.1
• Platform: Linux veritas 3.19.0-59-generic deprecate domains #66~14.04.1-Ubuntu SMP Fri May 13 17:27:10 UTC 2016 x86_64 GNU/Linux
• Subsystem:

It seems that several doctool tests depend on the availability of js-yaml in the source tree. js-yaml is supposedly included from the path tools/eslint/node_modules/js-yaml, which is not available in the source tarball. Running make lint in the source tree leads to the following error message:

Linting is not available through the source tarball.
Use the git repo instead: git clone https://github.com/nodejs/node.git

The actual offending test outputs, runnable via /usr/bin/python tools/test.py --mode=release -J doctool:

=== release test-doctool-html ===                    
Path: doctool/test-doctool-html
module.js:442
    throw err;
    ^

Error: Cannot find module '/home/jelle/temp/node-v6.2.1/tools/eslint/node_modules/js-yaml'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/jelle/temp/node-v6.2.1/tools/doc/node_modules/js-yaml/index.js:15:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
Command: out/Release/node /home/jelle/temp/node-v6.2.1/test/doctool/test-doctool-html.js
=== release test-doctool-json ===                    
Path: doctool/test-doctool-json
module.js:442
    throw err;
    ^

Error: Cannot find module '/home/jelle/temp/node-v6.2.1/tools/eslint/node_modules/js-yaml'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/jelle/temp/node-v6.2.1/tools/doc/node_modules/js-yaml/index.js:15:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)

I would expect that these tests should rather be skipped when running tests from an extracted tarball, or rewritten so they do not depend on eslint. Otherwise, eslint could possibly be included instead.

/cc @jbergstroem @silverwind @thealphanerd #6031

[silverwind]

Happens here: https://github.com/nodejs/node/blob/master/tools/doc/node_modules/js-yaml/index.js

@addaleax