Skip to content

failed test: parallel/test-tls-0-dns-altname when using shared openssl #617

Closed
@jbergstroem

Description

@jbergstroem
Path: parallel/test-tls-0-dns-altname
assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: "DNS:google.com, DNS:just-another.com, IP Address:8.8.8.8, IP Address:8.8.4.4, DNS:last.com" == "DNS:google.com\u0000.evil.com, DNS:just-another.com, IP Address:8.8.8.8, IP Address:8.8.4.4, DNS:last.com"
    at TLSSocket.<anonymous> (test/parallel/test-tls-0-dns-altname.js:29:12)
    at TLSSocket.g (events.js:184:16)
    at TLSSocket.emit (events.js:95:17)
    at TLSSocket.<anonymous> (_tls_wrap.js:910:18)
    at TLSSocket.emit (events.js:95:17)
    at TLSSocket._finishInit (_tls_wrap.js:436:8)

The test checks for process.versions.openssl, which will always exist regardless of using a shared library or not. I'm not sure what we want to do here -- possibly just rewrite the check?

Metadata

Metadata

Assignees

No one assigned

    Labels

    tlsIssues and PRs related to the tls subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions