FreeBSD with small-icu fails: g++ not found

[srl295]

• Version: master
• Platform: FreeBSD 10.3 amd64
• Subsystem: Intl

Split off from #6088 (comment)

When configured with env CXX=c++ CC=cc ./configure --with-intl=small-icu --download=all I get:

# ( lots of stuff compiled with cc and c++ and then… )  
  g++ '-DU_COMMON_IMPLEMENTATION=1' '-DU_I18N_IMPLEMENTATION=1' '-DU_IO_IMPLEMENTATION=1' '-DU_TOOLUTIL_IMPLEMENTATION=1' '-DU_ATTRIBUTE_DEPRECATED=' '-D_CRT_SECURE_NO_DEPRECATE=' '-DU_STATIC_IMPLEMENTATION=1' '-DUCONFIG_NO_TRANSLITERATION=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' '-DUCONFIG_NO_IDNA=1' -I../deps/icu-small/source/common -I../deps/icu-small/source/i18n -I../deps/icu-small/source/io -I../deps/icu-small/source/tools/toolutil  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -Wno-deprecated-declarations -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -frtti -MMD -MF /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd102-64/out/Release/.deps//usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd102-64/out/Release/obj.host/icutools/deps/icu-small/source/tools/toolutil/collationinfo.o.d.raw   -c -o /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd102-64/out/Release/obj.host/icutools/deps/icu-small/source/tools/toolutil/collationinfo.o ../deps/icu-small/source/tools/toolutil/collationinfo.cpp
gmake[2]: g++: Command not found

( I'm copying from https://ci.nodejs.org/job/node-test-commit-freebsd/2017/nodes=freebsd102-64/console but I had the same output locally ).

It's not clear where the g++ is coming from here. I think this is using the host toolset instead of target.

[bnoordhuis]

It's not clear where the g++ is coming from here. I think this is using the host toolset instead of target.

That's right. It's controlled by the CXX.host environment variable. It defaults (for better or worse) to g++.

[srl295]

@bnoordhuis Aha! so gmake CXX.host=c++ CC.host=cc seems to get a bit further. Thanks.

Perhaps the jenkins system needs to have this also.. @rvagg ?

[jbergstroem]

Looks like this: https://github.com/nodejs/node/blob/be68b68d4863f0d389cc46fdf6f1cbcd1b241d0a/tools/gyp/pylib/gyp/generator/make.py#L2056..L2065

I wouldn't treat this as FreeBSD only; lets either patch it by setting {CXX,CC}_host to CC/CXX in our Makefile (or override through env) or patch gyp. I can whip this up. Thoughts, @bnoordhuis? Also, just noting that I'm not a fan of what gyp does here.

[bnoordhuis]

Ideally, it gets fixed in gyp.

[srl295]

Also here (FreeBSD) host === target. So at least in that case, gyp shouldn't pick a different compiler.

[srl295]

@jbergstroem if you can whip up a patch that would be great. I'd be happy to keep this issue or turn it over, what ever you prefer.

[jbergstroem]

@srl295 I'm onto it. I've found a few bugs upstream that tangents modifying the environment default behaviour. I just don't see it change -- but I guess we could carry a patch.

[srl295]

this should be fixed by #6173 - close when confirmed.