Repository navigation
flaky: test-fs-cp #56794
Description
Activity
This might not be a flaky test since it failed even after a resume.
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32313/This test seems to have failure bursts (https://github.com/nodejs/reliability/issues?q=is%3Aissue%20state%3Aopen%20test-fs-cp). In each, there were a few PRs with all the failures.
However this time it is different, there are many different PRs affected by that and it only happens on Windows 11. We checked this and are fairly certain that this is caused by the latest Windows 11 updates (most likely will fail the same way on Windows 2025). Based on all of that I'll open a PR marking this test as flaky on Windows and will investigate it once it is no longer causing CI failures.
Reacted by Michael Dawson- added a commit that references this issue
on Jan 30, 2025 - added a commit that references this issue
on Feb 2, 2025 I opened 2 PRs (libuv/libuv#4696 and libuv/libuv#4698) in libuv and they landed. When a new version of libuv is released and merged into Node, this should be fixed.
- added a commit that references this issue
on Apr 2, 2025 Both libuv PRs have been present in the main branch but the test still seems very flaky: they are currently failing in almost all Windows CIs https://ci.nodejs.org/job/node-test-binary-windows-js-suites/
This seems to almost always fail now. I think we should consider splitting it and skipping the always failing test case, otherwise it will make the CI indefinitely orange.
Reacted by Antoine du Hamel, Alex Yang and Day1Banana- added a commit that references this issue
on Aug 10, 2025 - added 2 commits that reference this issue
on Aug 11, 2025 I tried to add some logs and compile on Windows:
diff --git a/src/node_file.cc b/src/node_file.cc index 44b4d4595e4..26e74814b64 100644 --- a/src/node_file.cc +++ b/src/node_file.cc @@ -3591,6 +3591,8 @@ static void CpSyncCopyDir(const FunctionCallbackInfo<Value>& args) { std::filesystem::copy_file( dir_entry.path(), dest_file_path, file_copy_opts, error); if (error) { + std::cout << error.message(); + printf("Error code: %d\n", error.value()); if (error.value() == EEXIST) { THROW_ERR_FS_CP_EEXIST(isolate, "[ERR_FS_CP_EEXIST]: Target already exists: "
out/Debug/node test/parallel/test-fs-cp-sync-error-on-exist.mjsprints:Le fichier existe.Error code: 80So the builtin error message says that the file exists, but the error code is not EEXIST.
According toerrno.hin Visual Studio, it is#define STRUNCATE 80.- added 3 commits that reference this issue
on Mar 2, 2026 This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
Test
test-fs-cp
Platform
Windows x64
Console output
Build links
Additional information
No response