Skip to content

Wrong version number in deps/openssl/openssl/Makefile on all release lines #5615

Closed
@rvagg

Description

@rvagg

Currently:

$ grep ^VERSION */deps/openssl/openssl/Makefile
master/deps/openssl/openssl/Makefile:VERSION=1.0.2f
node_0.10/deps/openssl/openssl/Makefile:VERSION=1.0.1r
node_0.12/deps/openssl/openssl/Makefile:VERSION=1.0.1r
node_4.x/deps/openssl/openssl/Makefile:VERSION=1.0.2f
node_5.x/deps/openssl/openssl/Makefile:VERSION=1.0.2f

We should be on 1.0.2g and 1.0.1s, I believe this is just a problem in the Makefile but it's what I'm currently using to figure out the version for https://nodejs.org/dist/index.tab and https://nodejs.org/dist/index.json and it's wrong for our recent releases.

  1. Can we get this fixed please and if it's not OpenSSL's fault, could we make sure it's part of the upgrade procedure to get it right?
  2. Is there s better way of getting the version, including historically? Maybe deps/openssl/openssl/include/openssl/opensslv.h is the authoritative location that I should be using?

@nodejs/crypto

Metadata

Metadata

Assignees

No one assigned

    Labels

    opensslIssues and PRs related to the OpenSSL dependency.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions