Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x] "Test and upload documentation to artifacts" workflow broken on v18.x-staging. #55754

Closed
richardlau opened this issue Nov 6, 2024 · 3 comments · Fixed by #55755
Closed

Comments

@richardlau
Copy link
Member

The Test and upload documentation to artifacts workflow is now failing for v18.x-staging. It looks to be caused by calling actions/setup-node with lts/* which now picks up Node.js 22.

e.g.

Example failure:

=== release test-doctool-json ===
Path: doctool/test-doctool-json
Error: --- stderr ---
node:assert:137
  throw err;
  ^

AssertionError [ERR_ASSERTION]: Unexpected global(s) found: navigator
    at process.<anonymous> (/home/runner/work/node/node/test/common/index.js:394:14)
    at process.emit (node:events:530:35) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: undefined,
  operator: 'fail'
}

Node.js v22.11.0
Command: /opt/hostedtoolcache/node/22.11.0/x64/bin/node /home/runner/work/node/node/test/doctool/test-doctool-json.mjs

cc @nodejs/releasers @nodejs/actions

@richardlau
Copy link
Member Author

Workflow may also be broken for v20.x-staging: https://github.com/nodejs/node/actions/runs/11686859060/job/32543621127 (from a closed pull request -- we haven't pushed to v20.x-staging recently to trigger the workflow).

@richardlau
Copy link
Member Author

Opened #55755 to pin the workflow to Node.js 20 for v20.x-staging.

aduh95 pushed a commit that referenced this issue Nov 7, 2024
To save time, the `.github/workflows/doc.yml` workflow runs
with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has
broken this workflow for Node.js 20 and 18 due to a mismatch
in globals. Pin the version of Node.js back to 20.

PR-URL: #55755
Fixes: #55754
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this issue Nov 7, 2024
To save time, the `.github/workflows/doc.yml` workflow runs
with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has
broken this workflow for Node.js 20 and 18 due to a mismatch
in globals. Pin the version of Node.js back to 20.

PR-URL: #55755
Fixes: #55754
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau
Copy link
Member Author

Fixed by #55755.

@richardlau richardlau linked a pull request Nov 7, 2024 that will close this issue
aduh95 pushed a commit that referenced this issue Nov 7, 2024
To save time, the `.github/workflows/doc.yml` workflow runs
with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has
broken this workflow for Node.js 20 and 18 due to a mismatch
in globals. Pin the version of Node.js back to 20.

PR-URL: #55755
Fixes: #55754
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant