Skip to content

Port/Duplicate async_hooks tests to use AsyncLocalStore #55712

Open
@Flarna

Description

@Flarna

Short after #55552 was merged I notices that this resulted in loosing a lot test for AsyncLocalStore.

Before AsyncLocalStore was based on async hooks. There are plenty of tests for async hooks which implict verified that AsyncLocalStore does what it is expected.

But since #55552 AsyncLocalStore and async hooks are independent.

I don't think we have to dup them all, but there are some special cases at least in HTTP area (e.g. here) which might require followups.

fyi @nodejs/diagnostics

Edit 21.11.: corrected link to PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    async_local_storageAsyncLocalStoragediag-agendaIssues and PRs to discuss during the meetings of the diagnostics working group.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions