Skip to content

build: configure path refactoring broke ICU download on windows #55214

Open
@srl295

Description

@srl295

Version

main

Platform

No response

Subsystem

build

What steps will reproduce the bug?

on windows git bash:

./configure --with-intl=full-icu --with-icu-source=https://github.com/unicode-org/icu/releases/download/release-76-rc/icu4c-76_1-src.tgz

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

successful configure

What do you see instead?

Traceback (most recent call last):
  File "C:\Users\srl29\src\node\configure", line 28, in <module>
    import configure
  File "C:\Users\srl29\src\node\configure.py", line 2204, in <module>
    configure_intl(output)
  File "C:\Users\srl29\src\node\configure.py", line 1939, in configure_intl
    elif with_icu_source and Path(icu_full_path).resolve() == Path(with_icu_source).resolve():
  File "C:\Users\srl29\.pyenv\pyenv-win\versions\3.9.13\lib\pathlib.py", line 1215, in resolve
    s = self._flavour.resolve(self, strict=strict)
  File "C:\Users\srl29\.pyenv\pyenv-win\versions\3.9.13\lib\pathlib.py", line 215, in resolve
    s = self._ext_to_normal(_getfinalpathname(s))
OSError: [WinError 123] El nombre de archivo, el nombre de directorio o la sintaxis de la etiqueta del volumen no son correctos: 'https:\\github.com\\unicode-org\\icu\\releases\\download\\release-76-rc\\icu4c-76_1-src.tgz'

Additional information

broke in #47581

Metadata

Metadata

Assignees

Labels

buildIssues and PRs related to build files or the CI.icuIssues and PRs related to the ICU dependency.pythonPRs and issues that require attention from people who are familiar with Python.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions