Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-http-regr-gh-2928 #5445

Closed
Trott opened this issue Feb 26, 2016 · 5 comments
Closed

Investigate flaky test-http-regr-gh-2928 #5445

Trott opened this issue Feb 26, 2016 · 5 comments
Assignees
@Trott
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Feb 26, 2016

Example failure:

Stress test confirmation: https://ci.nodejs.org/job/node-stress-single-test/528/nodes=smartos14-32/console

Ref: #4830
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Feb 26, 2016
@Trott Trott mentioned this issue Feb 26, 2016
Closed
@Trott
Copy link
Member Author

Trott commented Feb 26, 2016

/cc @mscdex

@Trott
Copy link
Member Author

Trott commented Feb 26, 2016

ARGH! This is the SmartOS bug that we actually patched a workaround for in test.py but the workaround is insufficient for tests that have a lot of connections. See 41519fd

@Trott
Copy link
Member Author

Trott commented Feb 26, 2016

Ref: #3960

@Trott
Copy link
Member Author

Trott commented Feb 26, 2016

Ref: #3941

@Trott Trott self-assigned this Feb 26, 2016
@Trott
Copy link
Member Author

Trott commented Feb 26, 2016

I think I have a working fix. Will run a Raspberry Pi stress test just to make sure I'm not re-introducing the issue on that platform by solving it for SmartOS. If all goes well, PR tomorrow.

@Trott Trott mentioned this issue Feb 26, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Mar 1, 2016
@Trott
test: retry on known SmartOS bug
bb388bc 
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-nodejsgh-2928` is one such test.

Fixes: nodejs#5445
Refs: nodejs#3941
PR-URL: nodejs#5454
@Trott Trott closed this as completed in 8592697 Mar 1, 2016
Fishrock123 pushed a commit that referenced this issue Mar 2, 2016
@Trott @Fishrock123
test: retry on known SmartOS bug
d1a82c6 
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-gh-2928` is one such test.

Fixes: #5445
Refs: #3941
PR-URL: #5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@Trott
test: retry on known SmartOS bug
7c0fc04 
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-gh-2928` is one such test.

Fixes: #5445
Refs: #3941
PR-URL: #5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@Trott
test: retry on known SmartOS bug
b4ef644 
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-gh-2928` is one such test.

Fixes: #5445
Refs: #3941
PR-URL: #5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Trott Trott

Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trott